From: Robert Olsson <[EMAIL PROTECTED]>
Date: Wed, 22 Feb 2006 19:47:13 +0100
>
> Jesse Brandeburg writes:
> >
> > I looked quickly at this on a couple different machines and wasn't
> > able to reproduce, so don't let me block the patch. I think its a
> > good patch FWIW
>
> OK!
> We as
Jesse Brandeburg writes:
>
> I looked quickly at this on a couple different machines and wasn't
> able to reproduce, so don't let me block the patch. I think its a
> good patch FWIW
OK!
We ask Deve to apply it.
Cheers.
--ro
-
To unsubscribe from
On 2/17/06, Robert Olsson <[EMAIL PROTECTED]> wrote:
>
> Arthur Kepner writes:
>
> Tanks. These races should be cured now I've tested a some runs and
> it works but I didn't see any problems before either. We'll hear from
> Jesse if this cured his problems.
I looked quickly at this on a couple
Arthur Kepner writes:
Tanks. These races should be cured now I've tested a some runs and
it works but I didn't see any problems before either. We'll hear from
Jesse if this cured his problems.
Cheers.
--ro
Signed-off-by: Robert Olsson <[EMAIL PROT
On Thu, 16 Feb 2006, Jesse Brandeburg wrote:
>
> should i test this patch to see if it fixes the pktgen panic when
> removing a network driver module (or renegotiating link, i don't
> remember where i saw the failure) in the middle of a pktgen run?
>
Yes, please.
Removing the network dri
On 2/15/06, Arthur Kepner <[EMAIL PROTECTED]> wrote:
>
> Let's try this again. How does this look, Robert?
>
> There's a race in pktgen which can lead to a double
> free of a pktgen_dev's skb. If a worker thread is in
> the midst of doing fill_packet(), and the controlling
> thread gets a "stop" me
On Thu, 16 Feb 2006, Robert Olsson wrote:
> .
> >if(remove) {
>
> > + t->control |= T_REMDEV;
> > + pkt_dev->removal_mark = 1;
>
> >}
>
> Guess you should mark b
Arthur Kepner writes:
>
> Let's try this again. How does this look, Robert?
Yeep better
> if(remove) {
> +t->control |= T_REMDEV;
> +pkt_dev->removal_mark = 1;
>
Let's try this again. How does this look, Robert?
There's a race in pktgen which can lead to a double
free of a pktgen_dev's skb. If a worker thread is in
the midst of doing fill_packet(), and the controlling
thread gets a "stop" message, the already freed skb
can be freed once again in pktgen_st
