Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread David Miller
From: Florian Fainelli Date: Tue, 17 May 2016 11:27:12 -0700 > On 05/17/2016 11:20 AM, David Miller wrote: >> From: Rabin Vincent >> Date: Mon, 16 May 2016 13:15:56 +0200 >> >>> From: Rabin Vincent >>> >>> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), >>> platforms which

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread Florian Fainelli
On 05/17/2016 11:20 AM, David Miller wrote: > From: Rabin Vincent > Date: Mon, 16 May 2016 13:15:56 +0200 > >> From: Rabin Vincent >> >> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), >> platforms which call fixed_phy_add() before fixed_mdio_bus_init() is >> called (for exa

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-17 Thread David Miller
From: Rabin Vincent Date: Mon, 16 May 2016 13:15:56 +0200 > From: Rabin Vincent > > Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), > platforms which call fixed_phy_add() before fixed_mdio_bus_init() is > called (for example, because the platform code and the fixed_phy driv

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-16 Thread Florian Fainelli
On 05/16/2016 06:40 AM, Andrew Lunn wrote: > On Mon, May 16, 2016 at 03:11:35PM +0200, Rabin Vincent wrote: >> On Mon, May 16, 2016 at 02:29:03PM +0200, Andrew Lunn wrote: >>> What i think is better is to make fixed_phy_add() return -EPROBE_DEFER >>> if it is called before fixed_mdio_bus_init(). >>

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-16 Thread Andrew Lunn
On Mon, May 16, 2016 at 03:11:35PM +0200, Rabin Vincent wrote: > On Mon, May 16, 2016 at 02:29:03PM +0200, Andrew Lunn wrote: > > What i think is better is to make fixed_phy_add() return -EPROBE_DEFER > > if it is called before fixed_mdio_bus_init(). > > I don't see how this will work for platform

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-16 Thread Rabin Vincent
On Mon, May 16, 2016 at 02:29:03PM +0200, Andrew Lunn wrote: > What i think is better is to make fixed_phy_add() return -EPROBE_DEFER > if it is called before fixed_mdio_bus_init(). I don't see how this will work for platforms such as ar7 and bcm47xx which call fixed_phy_add() from platform code.

Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-16 Thread Andrew Lunn
On Mon, May 16, 2016 at 01:15:56PM +0200, Rabin Vincent wrote: > From: Rabin Vincent > > Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), > platforms which call fixed_phy_add() before fixed_mdio_bus_init() is > called (for example, because the platform code and the fixed_phy d

[PATCH] phy: remove irq param to fix crash in fixed_phy_add()

2016-05-16 Thread Rabin Vincent
From: Rabin Vincent Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), platforms which call fixed_phy_add() before fixed_mdio_bus_init() is called (for example, because the platform code and the fixed_phy driver use the same initcall level) crash in fixed_phy_add() since the ->m