Re: [PATCH] padata: avoid race in reordering

2017-03-26 Thread Jason A. Donenfeld
I've got a few other races in padata, I think, that I'm working on fixing. If these pan out, I'll submit them exclusively to -crypto instead of -netdev, to avoid this confusion next time. Of course, if I'm able to fix these, then I'll probably be bald from pulling my hair out during this insane deb

Re: [PATCH] padata: avoid race in reordering

2017-03-25 Thread Herbert Xu
On Sat, Mar 25, 2017 at 08:01:51PM -0700, David Miller wrote: > From: Steffen Klassert > Date: Fri, 24 Mar 2017 10:41:59 +0100 > > > On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: > >> Under extremely heavy uses of padata, crashes occur, and with list > >> debugging turned on

Re: [PATCH] padata: avoid race in reordering

2017-03-25 Thread David Miller
From: Steffen Klassert Date: Fri, 24 Mar 2017 10:41:59 +0100 > On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: >> Under extremely heavy uses of padata, crashes occur, and with list >> debugging turned on, this happens instead: ... >> Signed-off-by: Jason A. Donenfeld > > Ac

Re: [PATCH] padata: avoid race in reordering

2017-03-24 Thread Herbert Xu
Jason A. Donenfeld wrote: > Under extremely heavy uses of padata, crashes occur, and with list > debugging turned on, this happens instead: > > [87487.298728] WARNING: CPU: 1 PID: 882 at lib/list_debug.c:33 > __list_add+0xae/0x130 > [87487.301868] list_add corruption. prev->next should be next >

Re: [PATCH] padata: avoid race in reordering

2017-03-24 Thread Steffen Klassert
On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: > Under extremely heavy uses of padata, crashes occur, and with list > debugging turned on, this happens instead: > > [87487.298728] WARNING: CPU: 1 PID: 882 at lib/list_debug.c:33 > __list_add+0xae/0x130 > [87487.301868] list_add

[PATCH] padata: avoid race in reordering

2017-03-23 Thread Jason A. Donenfeld
Under extremely heavy uses of padata, crashes occur, and with list debugging turned on, this happens instead: [87487.298728] WARNING: CPU: 1 PID: 882 at lib/list_debug.c:33 __list_add+0xae/0x130 [87487.301868] list_add corruption. prev->next should be next (b17abfc043d0), but was 8dba70872