On Tue, Dec 05, 2006 at 12:07:17PM -0800, Stephen Hemminger wrote:
> Fix sparse warnings and get rid of casts that hide misuse
> of __user pointers. There were two real bugs here:
> * ioctl was copying uninitialized stack om NETXEN_NIC_NAME
> * ioctl was dereferencing a user pointer
> in n
Stephen Hemminger wrote:
Fix sparse warnings and get rid of casts that hide misuse
of __user pointers. There were two real bugs here:
* ioctl was copying uninitialized stack om NETXEN_NIC_NAME
* ioctl was dereferencing a user pointer
in nettxen_nic_cmd_clear_stats.
IMHO the ioctl usage
On Wed, 6 Dec 2006 21:40:34 +0530
"Amit S. Kale" <[EMAIL PROTECTED]> wrote:
> Hi Stephen,
>
> This patch looks good.
>
> ioctls: NetXen chip is far more generic and will eventually show a
> significant
> amount of functionality in different products. We need ioctl analysis for
> user level t
Hi Stephen,
This patch looks good.
ioctls: NetXen chip is far more generic and will eventually show a significant
amount of functionality in different products. We need ioctl analysis for
user level tools that can tell states of registers etc. Removing ioctls all
together will make any analys
Fix sparse warnings and get rid of casts that hide misuse
of __user pointers. There were two real bugs here:
* ioctl was copying uninitialized stack om NETXEN_NIC_NAME
* ioctl was dereferencing a user pointer
in nettxen_nic_cmd_clear_stats.
IMHO the ioctl usage in this driver is going to