Re: [PATCH] netfilter: fix bad checksum on IPv6 when NAT is performed

2015-10-08 Thread Maxime Bizon
On Tue, 2015-10-06 at 16:23 +0200, Maxime Bizon wrote: > + if (maniptype == NF_NAT_MANIP_SRC) { > + from = ipv6h->saddr.s6_addr32; > + to = target->src.u3.in6.s6_addr32; > + } else { > + from = ipv6h->daddr.s6_addr32; > + to = target->src.u3

[PATCH] netfilter: fix bad checksum on IPv6 when NAT is performed

2015-10-06 Thread Maxime Bizon
With this setup: * non IPv6 checksumming capable network hardware * GRO off * IPv6 SNAT I get this when I receive an UDPv6 reply: ": hw csum failure" Call trace: * nf_ip6_checksum() calls __skb_checksum_complete() * nf_nat_ipv6_csum_update() & nf_nat_ipv6_manip_pkt() * __udp6_lib_rcv() => udp6

Re: [PATCH] netfilter: fix bad checksum on IPv6 when NAT is performed

2015-10-06 Thread Pablo Neira Ayuso
On Tue, Oct 06, 2015 at 04:10:52PM +0200, Maxime Bizon wrote: > > With this setup: > > * non IPv6 checksumming capable network hardware > * GRO off > * IPv6 SNAT > > I get this when I receive an UDPv6 reply: ": hw csum failure" > > Call trace: > > * nf_ip6_checksum() calls __skb_checksum_compl

[PATCH] netfilter: fix bad checksum on IPv6 when NAT is performed

2015-10-06 Thread Maxime Bizon
With this setup: * non IPv6 checksumming capable network hardware * GRO off * IPv6 SNAT I get this when I receive an UDPv6 reply: ": hw csum failure" Call trace: * nf_ip6_checksum() calls __skb_checksum_complete() * nf_nat_ipv6_csum_update() & nf_nat_ipv6_manip_pkt() * __udp6_lib_rcv() => udp6