Re: [PATCH] netfilter: add overflow checks in xt_bpf.c

2017-12-04 Thread Pablo Neira Ayuso
On Fri, Dec 01, 2017 at 01:46:07AM +0100, Jann Horn wrote: > Check whether inputs from userspace are too long (explicit length field too > big or string not null-terminated) to avoid out-of-bounds reads. > > As far as I can tell, this can at worst lead to very limited kernel heap > memory disclosu

Re: [PATCH] netfilter: add overflow checks in xt_bpf.c

2017-11-30 Thread Willem de Bruijn
On Thu, Nov 30, 2017 at 11:08 PM, Jann Horn wrote: > On Fri, Dec 1, 2017 at 5:04 AM, Willem de Bruijn > wrote: >> On Thu, Nov 30, 2017 at 7:46 PM, Jann Horn wrote: >>> Check whether inputs from userspace are too long (explicit length field too >>> big or string not null-terminated) to avoid out-

Re: [PATCH] netfilter: add overflow checks in xt_bpf.c

2017-11-30 Thread Jann Horn
On Fri, Dec 1, 2017 at 5:04 AM, Willem de Bruijn wrote: > On Thu, Nov 30, 2017 at 7:46 PM, Jann Horn wrote: >> Check whether inputs from userspace are too long (explicit length field too >> big or string not null-terminated) to avoid out-of-bounds reads. >> >> As far as I can tell, this can at wo

Re: [PATCH] netfilter: add overflow checks in xt_bpf.c

2017-11-30 Thread Willem de Bruijn
On Thu, Nov 30, 2017 at 7:46 PM, Jann Horn wrote: > Check whether inputs from userspace are too long (explicit length field too > big or string not null-terminated) to avoid out-of-bounds reads. > > As far as I can tell, this can at worst lead to very limited kernel heap > memory disclosure or oop

[PATCH] netfilter: add overflow checks in xt_bpf.c

2017-11-30 Thread Jann Horn
Check whether inputs from userspace are too long (explicit length field too big or string not null-terminated) to avoid out-of-bounds reads. As far as I can tell, this can at worst lead to very limited kernel heap memory disclosure or oopses. This bug can be triggered by an unprivileged user even