Re: [PATCH] netem: Segment GSO packets on enqueue.

2016-04-27 Thread Neil Horman
On Tue, Apr 26, 2016 at 01:19:15PM -0700, Eric Dumazet wrote: > On Tue, 2016-04-26 at 15:00 -0400, Neil Horman wrote: > > I can understand that, but that raises two questions in my mind: > > > > 1) Doesn't that make all the statistical manipulation for netem wrong? > > That is > > to say, if ne

Re: [PATCH] netem: Segment GSO packets on enqueue.

2016-04-26 Thread Eric Dumazet
On Tue, 2016-04-26 at 15:00 -0400, Neil Horman wrote: > I can understand that, but that raises two questions in my mind: > > 1) Doesn't that make all the statistical manipulation for netem wrong? That > is > to say, if netem drops 5% of packets, and it happens to drop a GSO packet, its > actual

Re: [PATCH] netem: Segment GSO packets on enqueue.

2016-04-26 Thread Neil Horman
On Tue, Apr 26, 2016 at 11:49:58AM -0700, Eric Dumazet wrote: > On Tue, 2016-04-26 at 13:43 -0400, Neil Horman wrote: > > This was recently reported to me, and reproduced on the latest net kernel, > > when > > attempting to run netperf from a host that had a netem qdisc attached to the > > egress

Re: [PATCH] netem: Segment GSO packets on enqueue.

2016-04-26 Thread Eric Dumazet
On Tue, 2016-04-26 at 13:43 -0400, Neil Horman wrote: > This was recently reported to me, and reproduced on the latest net kernel, > when > attempting to run netperf from a host that had a netem qdisc attached to the > egress interface: .. > The problem occurs because netem is not prepared to ha

[PATCH] netem: Segment GSO packets on enqueue.

2016-04-26 Thread Neil Horman
This was recently reported to me, and reproduced on the latest net kernel, when attempting to run netperf from a host that had a netem qdisc attached to the egress interface: [ 788.073771] [ cut here ] [ 788.096716] WARNING: at net/core/dev.c:2253 skb_warn_bad_offload+0xc