Re: [PATCH] net ipv4 ipconfig: use preferred log methods

2015-09-28 Thread David Miller
From: Bastian Stender Date: Fri, 25 Sep 2015 11:58:30 +0200 > @@ -69,7 +69,7 @@ > #undef IPCONFIG_DEBUG > > #ifdef IPCONFIG_DEBUG > -#define DBG(x) printk x > +#define DBG(x) pr_debug(x) > #else > #define DBG(x) do { } while(0) > #endif I agree with Stephen, just get rid of this and use p

Re: [PATCH] net ipv4 ipconfig: use preferred log methods

2015-09-27 Thread Stephen Hemminger
On Fri, 25 Sep 2015 11:58:30 +0200 Bastian Stender wrote: > > #ifdef IPCONFIG_DEBUG > -#define DBG(x) printk x > +#define DBG(x) pr_debug(x) > #else > #define DBG(x) do { } while(0) > #endif Why not remove all the local IPCONFIG_DEBUG stuff and just use pr_debug() like modern kernel code.

[PATCH] net ipv4 ipconfig: use preferred log methods

2015-09-25 Thread Bastian Stender
Replace printk calls with preferred log method calls to keep kernel messages clean. Signed-off-by: Bastian Stender --- net/ipv4/ipconfig.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index ed4ef0