Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

2018-03-09 Thread Marcelo Ricardo Leitner
On Fri, Mar 09, 2018 at 02:06:09PM +1100, Daniel Axtens wrote: > As well as the basic conversion, I noticed that a lot of the > SCTP code checks gso_type without first checking skb_is_gso() > so I have added that where appropriate. > > Also, document the helper. Thanks Daniel. > > Cc: Daniel Bo

Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

2018-03-09 Thread David Miller
From: Daniel Axtens Date: Fri, 9 Mar 2018 14:06:09 +1100 > As well as the basic conversion, I noticed that a lot of the > SCTP code checks gso_type without first checking skb_is_gso() > so I have added that where appropriate. > > Also, document the helper. > > Cc: Daniel Borkmann > Cc: Marcel

Re: [PATCH] net: use skb_is_gso_sctp() instead of open-coding

2018-03-09 Thread Daniel Borkmann
On 03/09/2018 04:06 AM, Daniel Axtens wrote: [...] > This depends on d02f51cbcf12 ("bpf: fix bpf_skb_adjust_net/bpf_skb_proto_xlat > to deal with gso sctp skbs") which introduces the required helper. > That is in the bpf tree at the moment. It's in net tree already by now: https://git.kernel.org/

[PATCH] net: use skb_is_gso_sctp() instead of open-coding

2018-03-08 Thread Daniel Axtens
As well as the basic conversion, I noticed that a lot of the SCTP code checks gso_type without first checking skb_is_gso() so I have added that where appropriate. Also, document the helper. Cc: Daniel Borkmann Cc: Marcelo Ricardo Leitner Signed-off-by: Daniel Axtens --- This depends on d02f5