RE: [PATCH] net: use non-compound pages in frag allocator

2016-08-04 Thread Ilya Lesokhin
ric Dumazet [mailto:eric.duma...@gmail.com] > Sent: Thursday, August 04, 2016 4:25 PM > To: Ilya Lesokhin > Cc: netdev@vger.kernel.org; eduma...@google.com > Subject: Re: [PATCH] net: use non-compound pages in frag allocator > > On Thu, 2016-08-04 at 15:47 +0300, Ilya Lesokhin wrote:

Re: [PATCH] net: use non-compound pages in frag allocator

2016-08-04 Thread Eric Dumazet
On Thu, 2016-08-04 at 13:38 +, Ilya Lesokhin wrote: > You are right I just realized that this patch causes a memory leak, so sorry > for the spam. > > I just had problem understanding when compound pages are needed and when It > is enough to use an high order pages. > I thought that that hig

Re: [PATCH] net: use non-compound pages in frag allocator

2016-08-04 Thread Eric Dumazet
On Thu, 2016-08-04 at 15:47 +0300, Ilya Lesokhin wrote: > The code currently always references the first page in the > frag therefore there is no need to pay the extra overhead > of making the frag page compound > > Signed-off-by: Ilya Lesokhin > --- > net/core/sock.c | 2 +- > 1 file changed, 1

[PATCH] net: use non-compound pages in frag allocator

2016-08-04 Thread Ilya Lesokhin
The code currently always references the first page in the frag therefore there is no need to pay the extra overhead of making the frag page compound Signed-off-by: Ilya Lesokhin --- net/core/sock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock.c b/net/core/so