Re: [PATCH] net: tcp: fix rx timestamp behavior for tcp_recvmsg

2020-05-07 Thread Willem de Bruijn
On Tue, May 5, 2020 at 4:23 PM Willem de Bruijn wrote: > > On Mon, May 4, 2020 at 12:30 PM Kelly Littlepage wrote: > > > > Timestamping cmsgs are not returned when the user buffer supplied to > > recvmsg is too small to copy at least one skbuff in entirety. > > In general a tcp reader should not

Re: [PATCH] net: tcp: fix rx timestamp behavior for tcp_recvmsg

2020-05-05 Thread Willem de Bruijn
On Mon, May 4, 2020 at 12:30 PM Kelly Littlepage wrote: > > Timestamping cmsgs are not returned when the user buffer supplied to > recvmsg is too small to copy at least one skbuff in entirety. In general a tcp reader should not make any assumptions on packetization of the bytestream, including th

[PATCH] net: tcp: fix rx timestamp behavior for tcp_recvmsg

2020-05-04 Thread Kelly Littlepage
Timestamping cmsgs are not returned when the user buffer supplied to recvmsg is too small to copy at least one skbuff in entirety. Support for TCP rx timestamps came from commit 98aaa913b4ed ("tcp: Extend SOF_TIMESTAMPING_RX_SOFTWARE to TCP recvmsg") which noted that the cmsg should "return the tim