Re: [PATCH] net: systemport: free dev before on error path

2021-01-20 Thread Jakub Kicinski
On Tue, 19 Jan 2021 21:07:10 -0800 Florian Fainelli wrote: > On 1/19/2021 8:44 PM, Pan Bian wrote: > > On the error path, it should goto the error handling label to free > > allocated memory rather than directly return. > > > > Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock") > >

Re: [PATCH] net: systemport: free dev before on error path

2021-01-19 Thread Florian Fainelli
On 1/19/2021 8:44 PM, Pan Bian wrote: > On the error path, it should goto the error handling label to free > allocated memory rather than directly return. > > Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock") > Signed-off-by: Pan Bian The change is correct, but not the Fixes t

[PATCH] net: systemport: free dev before on error path

2021-01-19 Thread Pan Bian
On the error path, it should goto the error handling label to free allocated memory rather than directly return. Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock") Signed-off-by: Pan Bian --- drivers/net/ethernet/broadcom/bcmsysport.c | 6 -- 1 file changed, 4 insertions(+), 2