Re: [PATCH] net: sysctl: fix a kmemleak warning

2015-10-23 Thread Li RongQing
On Fri, Oct 23, 2015 at 6:04 PM, David Miller wrote: >> +out1: >> + unregister_sysctl_table(net_header); >> + kfree(net_header); > > I read over unregister_sysctl_table() and it appears to do the kfree() > for us, doesn't it? you are right, thanks -Roy -- To unsubscribe from this list:

Re: [PATCH] net: sysctl: fix a kmemleak warning

2015-10-23 Thread David Miller
From: roy.qing...@gmail.com Date: Thu, 22 Oct 2015 11:27:12 +0800 > +out1: > + unregister_sysctl_table(net_header); > + kfree(net_header); I read over unregister_sysctl_table() and it appears to do the kfree() for us, doesn't it? -- To unsubscribe from this list: send the line "unsubscrib

[PATCH] net: sysctl: fix a kmemleak warning

2015-10-21 Thread roy . qing . li
From: Li RongQing the returned buffer of register_sysctl() is stored into net_header variable, but net_header is not used after, and compiler maybe optimise the variable out, and lead kmemleak reported the below warning comm "swapper/0", pid 1, jiffies 4294937448 (age 267.270s) h