Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-28 Thread Vadim Lomovtsev
On Fri, Aug 25, 2017 at 06:01:28PM -0400, J. Bruce Fields wrote: > On Fri, Aug 18, 2017 at 06:00:47AM -0400, Vadim Lomovtsev wrote: > > While running nfs/connectathon tests kernel NULL-pointer exception > > has been observed due to races in svcsock.c. > > > > Race is appear when kernel accepts con

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-25 Thread J. Bruce Fields
On Fri, Aug 18, 2017 at 06:00:47AM -0400, Vadim Lomovtsev wrote: > While running nfs/connectathon tests kernel NULL-pointer exception > has been observed due to races in svcsock.c. > > Race is appear when kernel accepts connection by kernel_accept > (which creates new socket) and start queuing ing

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-18 Thread Vadim Lomovtsev
On Fri, Aug 18, 2017 at 07:16:45AM -0400, Jeff Layton wrote: > On Fri, 2017-08-18 at 07:08 -0400, Vadim Lomovtsev wrote: > > Hi Jeff, > > > > On Fri, Aug 18, 2017 at 06:27:32AM -0400, Jeff Layton wrote: > > > On Fri, 2017-08-18 at 06:00 -0400, Vadim Lomovtsev wrote: > > > > While running nfs/conne

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-18 Thread Jeff Layton
On Fri, 2017-08-18 at 07:08 -0400, Vadim Lomovtsev wrote: > Hi Jeff, > > On Fri, Aug 18, 2017 at 06:27:32AM -0400, Jeff Layton wrote: > > On Fri, 2017-08-18 at 06:00 -0400, Vadim Lomovtsev wrote: > > > While running nfs/connectathon tests kernel NULL-pointer exception > > > has been observed due t

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-18 Thread Vadim Lomovtsev
Hi Jeff, On Fri, Aug 18, 2017 at 06:27:32AM -0400, Jeff Layton wrote: > On Fri, 2017-08-18 at 06:00 -0400, Vadim Lomovtsev wrote: > > While running nfs/connectathon tests kernel NULL-pointer exception > > has been observed due to races in svcsock.c. > > > > Race is appear when kernel accepts conn

Re: [PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-18 Thread Jeff Layton
On Fri, 2017-08-18 at 06:00 -0400, Vadim Lomovtsev wrote: > While running nfs/connectathon tests kernel NULL-pointer exception > has been observed due to races in svcsock.c. > > Race is appear when kernel accepts connection by kernel_accept > (which creates new socket) and start queuing ingress pa

[PATCH] net: sunrpc: svcsock: fix NULL-pointer exception

2017-08-18 Thread Vadim Lomovtsev
While running nfs/connectathon tests kernel NULL-pointer exception has been observed due to races in svcsock.c. Race is appear when kernel accepts connection by kernel_accept (which creates new socket) and start queuing ingress packets to new socket. This happanes in ksoftirq context which concurr