Re: [PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Sergei Shtylyov
On 03/02/2016 08:11 PM, Wolfram Sang wrote: Reported-by: coverity (CID 1056464) Signed-off-by: Wolfram Sang Will you respin or should I? Please go ahead. You have more knowledge about this driver, so you will be faster. Not necessarily -- I have other bug to chase right now. :-)

Re: [PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Wolfram Sang
> >Reported-by: coverity (CID 1056464) > >Signed-off-by: Wolfram Sang > >Will you respin or should I? Please go ahead. You have more knowledge about this driver, so you will be faster. Reported-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Sergei Shtylyov
Hello. On 03/02/2016 06:26 PM, Wolfram Sang wrote: From: Wolfram Sang When allocating an skb fails, rxdesc is still NULL (or the previous ring index on further iterations of the loop). However, this pointer is dereferenced after the loop. This is intended. What we seem to actually need i

[PATCH] net: sh_eth: avoid NULL pointer dereference in ring setup

2016-03-02 Thread Wolfram Sang
From: Wolfram Sang When allocating an skb fails, rxdesc is still NULL (or the previous ring index on further iterations of the loop). However, this pointer is dereferenced after the loop. So, make sure rxdesc is updated immediately at the beginning of the loop. Reported-by: coverity (CID 1056464