Re: [PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-15 Thread Daniel Axtens
Hi Marcelo, > > If this block was meant to be an out-of-band/changelog comment, your > SOB line should be above the first --- marker. > Anyhow, > Reviewed-by: Marcelo Ricardo Leitner Thanks - I did a v2 with this around the right way [1], but DaveM asked me to be a bit more thorough and look for

Re: [PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-15 Thread Marcelo Ricardo Leitner
On Mon, Feb 05, 2018 at 02:34:33PM +1100, Daniel Axtens wrote: > tbf_enqueue() checks the size of a packet before enqueuing it. > However, the GSO size check does not consider the GSO_BY_FRAGS > case, and so will drop GSO SCTP packets, causing a massive drop > in throughput. > > Use skb_gso_valida

[PATCH] net: sched: tbf: handle GSO_BY_FRAGS case in enqueue

2018-02-04 Thread Daniel Axtens
tbf_enqueue() checks the size of a packet before enqueuing it. However, the GSO size check does not consider the GSO_BY_FRAGS case, and so will drop GSO SCTP packets, causing a massive drop in throughput. Use skb_gso_validate_mac_len() instead, as it does consider that case. --- skb_gso_validate