Re: [PATCH] net: phy: sftp: print debug message with text, not numbers

2018-08-08 Thread Andrew Lunn
On Wed, Aug 08, 2018 at 11:16:57PM +0100, Russell King - ARM Linux wrote: > You might want to fix the subject line. Ah, yes, s/sftp/sfp/ Thanks Andrew

Re: [PATCH] net: phy: sftp: print debug message with text, not numbers

2018-08-08 Thread Russell King - ARM Linux
You might want to fix the subject line. On Wed, Aug 08, 2018 at 08:54:12PM +0200, Andrew Lunn wrote: > Convert the state numbers, device state, etc from numbers to strings > when printing debug messages. > > Signed-off-by: Andrew Lunn > --- > drivers/net/phy/sfp.c | 76 +

Re: [PATCH] net: phy: sftp: print debug message with text, not numbers

2018-08-08 Thread Andrew Lunn
On Wed, Aug 08, 2018 at 12:02:56PM -0700, Florian Fainelli wrote: > On 08/08/2018 11:54 AM, Andrew Lunn wrote: > > Convert the state numbers, device state, etc from numbers to strings > > when printing debug messages. > > I had a similar patch locally that I used for initial troubleshooting, > whi

Re: [PATCH] net: phy: sftp: print debug message with text, not numbers

2018-08-08 Thread Florian Fainelli
On 08/08/2018 11:54 AM, Andrew Lunn wrote: > Convert the state numbers, device state, etc from numbers to strings > when printing debug messages. I had a similar patch locally that I used for initial troubleshooting, which I might even have shared with Russell at some point, though now I can't rem

[PATCH] net: phy: sftp: print debug message with text, not numbers

2018-08-08 Thread Andrew Lunn
Convert the state numbers, device state, etc from numbers to strings when printing debug messages. Signed-off-by: Andrew Lunn --- drivers/net/phy/sfp.c | 76 --- 1 file changed, 72 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers