Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Bixuan Cui
On 2020/7/20 1:05, Stephen Hemminger wrote: > On Thu, 16 Jul 2020 17:32:47 + > Bixuan Cui wrote: > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37': >> drivers/net/ethernet/neterion/vxge/

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Stephen Hemminger
On Thu, 16 Jul 2020 17:32:47 + Bixuan Cui wrote: > Fix the warning: [-Werror=-Wframe-larger-than=] > > drivers/net/ethernet/neterion/vxge/vxge-main.c: > In function'VXGE_COMPLETE_VPATH_TX.isra.37': > drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: > warning: the frame size of 1056 byte

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread kernel test robot
Hi Bixuan, Thank you for the patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on net-next/master net/master linus/master v5.8-rc5 next-20200716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread kernel test robot
Hi Bixuan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on sparc-next/master] [also build test WARNING on net-next/master net/master linus/master v5.8-rc5 next-20200716] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread Bixuan Cui
On 2020/7/16 17:46, Joe Perches wrote: > I doubt this is a good idea. > Check the callers interrupt status. yes, it's not good idea to alloc memory in interrupt handler, I will think more while fix warning. :) Thanks.

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread Joe Perches
On Thu, 2020-07-16 at 17:32 +, Bixuan Cui wrote: > Fix the warning: [-Werror=-Wframe-larger-than=] [] > diff --git a/drivers/net/ethernet/neterion/vxge/vxge-main.c > b/drivers/net/ethernet/neterion/vxge/vxge-main.c [] > @@ -100,8 +100,14 @@ static inline void VXGE_COMPLETE_VPATH_TX(struct > v

[PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread Bixuan Cui
Fix the warning: [-Werror=-Wframe-larger-than=] drivers/net/ethernet/neterion/vxge/vxge-main.c: In function'VXGE_COMPLETE_VPATH_TX.isra.37': drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: warning: the frame size of 1056 bytes is larger than 1024 bytes Signed-off-by: Bixuan Cui --- driver