Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-27 Thread Eric Dumazet
On 02/27/2019 03:26 AM, Sheng Lan wrote: > > I traced again and found that the skb was not sent, master skb was still in > write queue, > because the function tcp_transmit_skb() returns 1 (NET_XMIT_DROP), thus it > can be retransmit. > I found the error value NET_XMIT_DROP returns from netem

Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-27 Thread Sheng Lan
在 2019/2/26 23:52, Eric Dumazet 写道: > > > On 02/26/2019 05:02 AM, Sheng Lan wrote: >> >> >> >>> On Mon, 25 Feb 2019 22:49:39 +0800 >>> Sheng Lan wrote: >>> >>>> From: Sheng Lan >>>> Subject: [PATCH] net: ne

Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-26 Thread Eric Dumazet
On 02/26/2019 07:59 AM, Stephen Hemminger wrote: > > > Maybe the fix is to stop TSO fragment from overwriting by doing something > like: > > diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c > index 730bc44dbad9..5fe91d0224f6 100644 > --- a/net/ipv4/tcp_output.c > +++ b/net/ipv4/tc

Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-26 Thread Stephen Hemminger
On Tue, 26 Feb 2019 21:02:10 +0800 Sheng Lan wrote: > > On Mon, 25 Feb 2019 22:49:39 +0800 > > Sheng Lan wrote: > > > >> From: Sheng Lan > >> Subject: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec > >> > >> It can be re

Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-26 Thread Eric Dumazet
On 02/26/2019 05:02 AM, Sheng Lan wrote: > > > >> On Mon, 25 Feb 2019 22:49:39 +0800 >> Sheng Lan wrote: >> >>> From: Sheng Lan >>> Subject: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec >>> >>> It can be reproduc

Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-26 Thread Sheng Lan
> On Mon, 25 Feb 2019 22:49:39 +0800 > Sheng Lan wrote: > >> From: Sheng Lan >> Subject: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec >> >> It can be reproduced by following steps: >> 1. virtio_net NIC is configured with gso/tso on >&

Re: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-25 Thread Stephen Hemminger
On Mon, 25 Feb 2019 22:49:39 +0800 Sheng Lan wrote: > From: Sheng Lan > Subject: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec > > It can be reproduced by following steps: > 1. virtio_net NIC is configured with gso/tso on > 2. configure nginx as http server

[PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec

2019-02-25 Thread Sheng Lan
From: Sheng Lan Subject: [PATCH] net: netem: fix skb length BUG_ON in __skb_to_sgvec It can be reproduced by following steps: 1. virtio_net NIC is configured with gso/tso on 2. configure nginx as http server with an index file bigger than 1M bytes 3. use tc netem to produce duplicate packets and