Re: [PATCH] net: mvpp2: initialize port of_node pointer

On Mon, Aug 27, 2018 at 09:17:21PM +0300, Baruch Siach wrote: > Hi Andrew, > > Thanks for reviewing. > > On Mon, Aug 27, 2018 at 03:47:23PM +0200, Andrew Lunn wrote: > > On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote: > > > Without a valid of_node in struct device we can't find the

Re: [PATCH] net: mvpp2: initialize port of_node pointer

Hi Andrew, Thanks for reviewing. On Mon, Aug 27, 2018 at 03:47:23PM +0200, Andrew Lunn wrote: > On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote: > > Without a valid of_node in struct device we can't find the mvpp2 port > > device by its DT node. Specifically, this breaks > > of_find_

Re: [PATCH] net: mvpp2: initialize port of_node pointer

On Mon, Aug 27, 2018 at 03:12:53PM +0300, Baruch Siach wrote: > Without a valid of_node in struct device we can't find the mvpp2 port > device by its DT node. Specifically, this breaks > of_find_net_device_by_node(). Hi Baruch We need to be a little bit careful here. I've seen this done wrongly b

[PATCH] net: mvpp2: initialize port of_node pointer

Without a valid of_node in struct device we can't find the mvpp2 port device by its DT node. Specifically, this breaks of_find_net_device_by_node(). Signed-off-by: Baruch Siach --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/eth