Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

Hi Daniel, On Sun, Jun 07, 2020 at 02:25:11AM +0200, Daniel González Cabanelas wrote: > Hi Russell, > > El vie., 5 jun. 2020 a las 11:49, Russell King - ARM Linux admin > () escribió: > > > > On Thu, May 21, 2020 at 05:55:19PM +0200, Daniel González Cabanelas wrote: > > > Thanks for the comments.

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

Hi Russell, El vie., 5 jun. 2020 a las 11:49, Russell King - ARM Linux admin () escribió: > > On Thu, May 21, 2020 at 05:55:19PM +0200, Daniel González Cabanelas wrote: > > Thanks for the comments. > > > > I'll look for a better approach. > > > Hi Daniel, > > I've just pushed out phylink a patch a

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

On Thu, May 21, 2020 at 05:55:19PM +0200, Daniel González Cabanelas wrote: > Thanks for the comments. > > I'll look for a better approach. Hi Daniel, I've just pushed out phylink a patch adding this functionality. I'm intending to submit it when net-next re-opens. See: http://git.armlinux.org.

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

From: Russell King - ARM Linux admin Date: Thu, 21 May 2020 19:20:10 +0100 > David, can you revert 5e3768a436bb70c9c3e27aaba6b73f8ef8f5dcf3 please? > It's a layering violation, and as Andrew has found, it causes kernel > oopses. Done.

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

On Thu, May 21, 2020 at 05:55:13PM +0200, Andrew Lunn wrote: > > I hope the patch adding pp->dev->phydev hasn't been merged as it's > > almost certainly wrong. > > Hi Russell > > It was merged :-( > > And it Oops when used with a switch. Hmm, now that I have net-next updated, I think the origin

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

Thanks for the comments. I'll look for a better approach. Regards Daniel El jue., 21 may. 2020 a las 17:27, Russell King - ARM Linux admin () escribió: > > On Thu, May 21, 2020 at 05:19:16PM +0200, Andrew Lunn wrote: > > > drivers/net/ethernet/marvell/mvneta.c | 7 --- > > > 1 file changed,

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

On 5/21/2020 8:26 AM, Russell King - ARM Linux admin wrote: > On Thu, May 21, 2020 at 05:19:16PM +0200, Andrew Lunn wrote: >>> drivers/net/ethernet/marvell/mvneta.c | 7 --- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/ethernet/marvell/mvneta.c >>> b

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

> I hope the patch adding pp->dev->phydev hasn't been merged as it's > almost certainly wrong. Hi Russell It was merged :-( And it Oops when used with a switch. Andrew

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

On Thu, May 21, 2020 at 05:19:16PM +0200, Andrew Lunn wrote: > > drivers/net/ethernet/marvell/mvneta.c | 7 --- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/ethernet/marvell/mvneta.c > > b/drivers/net/ethernet/marvell/mvneta.c > > index 41d2a0eac..f917

Re: [PATCH] net: mvneta: only do WoL speed down if the PHY is valid

> drivers/net/ethernet/marvell/mvneta.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c > b/drivers/net/ethernet/marvell/mvneta.c > index 41d2a0eac..f9170bc93 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/driver

[PATCH] net: mvneta: only do WoL speed down if the PHY is valid

Previous patch: "net: mvneta: speed down the PHY, if WoL used, to save energy" was causing a NULL pointer dereference when ethernet switches are connected to mvneta, because they aren't handled directly as PHYs. Fix it by restricting the mentioned patch for the PHY detected cases. Reported-by: