Re: [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync

2020-06-15 Thread David Miller
From: Navid Emamdoost Date: Sun, 14 Jun 2020 00:48:03 -0500 > in macb_mdio_write, macb_mdio_read, and at91ether_open, > pm_runtime_get_sync is called which increments the counter even in case of > failure, leading to incorrect ref count. > In case of failure, decrement the ref count before return

Re: [PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync

2020-06-14 Thread Markus Elfring
> in macb_mdio_write, … * Will a desire evolve to improve also this commit message? * Will the tag “Fixes” become helpful? … > +++ b/drivers/net/ethernet/cadence/macb_main.c … > @@ -3840,11 +3842,14 @@ static int at91ether_open(struct net_device *dev) > > ret = macb_phylink_connect(lp);

[PATCH] net: macb: fix ref count leaking via pm_runtime_get_sync

2020-06-13 Thread Navid Emamdoost
in macb_mdio_write, macb_mdio_read, and at91ether_open, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/cadenc