Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Hi Andrew, On 14/05/19 14:35, Andrew Lunn wrote: > On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: >> Errors are negative numbers. Using %u shows them as very large positive >> numbers such as 4294967277 that don't make sense. Use the %d format >> instead, and get a much nicer -19.

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Andrew Lunn
On Tue, May 14, 2019 at 09:14:50AM +0200, Luca Ceresoli wrote: > Errors are negative numbers. Using %u shows them as very large positive > numbers such as 4294967277 that don't make sense. Use the %d format > instead, and get a much nicer -19. Hi Luca Do you consider this a fix? If so, it should

Re: [PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Nicolas.Ferre
On 14/05/2019 at 09:14, Luca Ceresoli wrote: > External E-Mail > > > Errors are negative numbers. Using %u shows them as very large positive > numbers such as 4294967277 that don't make sense. Use the %d format > instead, and get a much nicer -19. > > Signed-off-by: Luca Ceresoli Indeed! Acked

[PATCH] net: macb: fix error format in dev_err()

2019-05-14 Thread Luca Ceresoli
Errors are negative numbers. Using %u shows them as very large positive numbers such as 4294967277 that don't make sense. Use the %d format instead, and get a much nicer -19. Signed-off-by: Luca Ceresoli --- drivers/net/ethernet/cadence/macb_main.c | 16 1 file changed, 8 insert