Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-06 Thread David Miller
From: Florian Larysch Date: Mon, 3 Apr 2017 16:46:09 +0200 > inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to > ip_route_input when iif is given. If a multipath route is present for > the designated destination, ip_multipath_icmp_hash ends up being called, > which uses the s

Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-03 Thread Florian Larysch
On Mon, Apr 03, 2017 at 01:33:39PM -0400, David Ahern wrote: > that function no longer exists since Nik's recent work > (bf4e0a3db97eb882368fd82980b3b1fa0b5b9778) Didn't notice that as I was looking at Linus' tree. Thanks. > So does the problem you noted still exist? Yes. And in fact, that chang

Re: [PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-03 Thread David Ahern
On 4/3/17 10:46 AM, Florian Larysch wrote: > inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to > ip_route_input when iif is given. If a multipath route is present for > the designated destination, ip_multipath_icmp_hash ends up being called, that function no longer exists since

[PATCH] net: ipv4: fix multipath RTM_GETROUTE behavior when iif is given

2017-04-03 Thread Florian Larysch
inet_rtm_getroute synthesizes a skeletal ICMP skb, which is passed to ip_route_input when iif is given. If a multipath route is present for the designated destination, ip_multipath_icmp_hash ends up being called, which uses the source/destination addresses within the skb to calculate a hash. Howeve