RE: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-26 Thread Brown, Aaron F
. Silva > Subject: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on > e1e_wphy() return value > > Check return value from call to e1e_wphy(). This value is being > checked during previous calls to function e1e_wphy() and it seems > a check was missing here. > > Addr

Re: [Intel-wired-lan] [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-21 Thread Neftin, Sasha
On 21/06/2017 22:52, Gustavo A. R. Silva wrote: Hi Ethan, Quoting Ethan Zhao : Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao Thank yo

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-21 Thread Gustavo A. R. Silva
Hi Ethan, Quoting Ethan Zhao : Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao Thank you very much for the clarification. On Wed, Jun 21

Re: [PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Ethan Zhao
Gustavo, The return value of ret_val seems used to check if the access to PHY/NVM got its semaphore, generally speaking, it is needed for every PHY access of this driver. Reviewed-by: Ethan Zhao On Wed, Jun 21, 2017 at 5:22 AM, Gustavo A. R. Silva wrote: > Check return value from call to e

[PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Gustavo A. R. Silva
Check return value from call to e1e_wphy(). This value is being checked during previous calls to function e1e_wphy() and it seems a check was missing here. Addresses-Coverity-ID: 1226905 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 2 ++ 1 file changed, 2