Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-15 Thread Joe Perches
On Wed, 2017-02-15 at 11:38 +0100, Tobias Klauser wrote: > On 2017-02-15 at 11:28:08 +0100, Joe Perches wrote: > > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > > > hip04_get_stats() just returns dev->stats so we can leave it > > > out altogether and let dev_get_stats() do the job. >

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-15 Thread Tobias Klauser
On 2017-02-15 at 11:28:08 +0100, Joe Perches wrote: > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > > hip04_get_stats() just returns dev->stats so we can leave it > > out altogether and let dev_get_stats() do the job. > > This could be done for at least a few more drivers: > > drive

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-15 Thread Joe Perches
On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote: > hip04_get_stats() just returns dev->stats so we can leave it > out altogether and let dev_get_stats() do the job. This could be done for at least a few more drivers: drivers/net/ethernet/chelsio/cxgb/sge.c drivers/net/ethernet/intel/e1000

Re: [PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-14 Thread David Miller
From: Tobias Klauser Date: Tue, 14 Feb 2017 15:10:06 +0100 > hip04_get_stats() just returns dev->stats so we can leave it > out altogether and let dev_get_stats() do the job. > > Signed-off-by: Tobias Klauser Applied to net-next, thank you.

[PATCH] net: hip04: Omit private ndo_get_stats function

2017-02-14 Thread Tobias Klauser
hip04_get_stats() just returns dev->stats so we can leave it out altogether and let dev_get_stats() do the job. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/hisilicon/hip04_eth.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/driv