Re: [PATCH] net: ftgmac100: Fix crash when removing driver

2020-11-15 Thread Joel Stanley
On Thu, 12 Nov 2020 at 23:22, Jakub Kicinski wrote: > > On Thu, 12 Nov 2020 11:01:45 +1030 Joel Stanley wrote: > > When removing the driver we would hit > > BUG_ON(!list_empty(&dev->ptype_specific)) > > in net/core/dev.c due to still having the NC-SI packet handler > > registered. > > > Fixes: bd

Re: [PATCH] net: ftgmac100: Fix crash when removing driver

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 11:01:45 +1030 Joel Stanley wrote: > When removing the driver we would hit > BUG_ON(!list_empty(&dev->ptype_specific)) > in net/core/dev.c due to still having the NC-SI packet handler > registered. > Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode") > Signed-off-by: Joel

[PATCH] net: ftgmac100: Fix crash when removing driver

2020-11-11 Thread Joel Stanley
When removing the driver we would hit BUG_ON(!list_empty(&dev->ptype_specific)) in net/core/dev.c due to still having the NC-SI packet handler registered. # echo 1e66.ethernet > /sys/bus/platform/drivers/ftgmac100/unbind [ cut here ] kernel BUG at net/core/dev.c:10