Re: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed

2020-05-09 Thread Jakub Kicinski
On Sat, 9 May 2020 15:04:04 -0700 Florian Fainelli wrote: > On 5/9/2020 2:48 PM, Arnd Bergmann wrote: > > On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski wrote: > >> > >> On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote: > >>> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m

Re: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed

2020-05-09 Thread Florian Fainelli
On 5/9/2020 2:48 PM, Arnd Bergmann wrote: > On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski wrote: >> >> On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote: >>> I ran into a randconfig build failure with CONFIG_FIXED_PHY=m >>> and CONFIG_GIANFAR=y: >>> >>> x86_64-linux-ld: drivers/net/ethern

Re: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed

2020-05-09 Thread Arnd Bergmann
On Sat, May 9, 2020 at 10:24 PM Jakub Kicinski wrote: > > On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote: > > I ran into a randconfig build failure with CONFIG_FIXED_PHY=m > > and CONFIG_GIANFAR=y: > > > > x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): > > unde

Re: [PATCH] net: freescale: select CONFIG_FIXED_PHY where needed

2020-05-09 Thread Jakub Kicinski
On Sat, 9 May 2020 14:04:52 +0200 Arnd Bergmann wrote: > I ran into a randconfig build failure with CONFIG_FIXED_PHY=m > and CONFIG_GIANFAR=y: > > x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): > undefined reference to `fixed_phy_change_carrier' > > It seems the same

[PATCH] net: freescale: select CONFIG_FIXED_PHY where needed

2020-05-09 Thread Arnd Bergmann
I ran into a randconfig build failure with CONFIG_FIXED_PHY=m and CONFIG_GIANFAR=y: x86_64-linux-ld: drivers/net/ethernet/freescale/gianfar.o:(.rodata+0x418): undefined reference to `fixed_phy_change_carrier' It seems the same thing can happen with dpaa and ucc_geth, so change all three to do an