Re: [PATCH] net: fix race in process_backlog

2007-10-03 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 3 Oct 2007 15:05:19 -0700 > On Wed, 03 Oct 2007 14:58:07 -0700 (PDT) > David Miller <[EMAIL PROTECTED]> wrote: > > > From: Peter Zijlstra <[EMAIL PROTECTED]> > > Date: Wed, 03 Oct 2007 17:44:53 +0200 > > > > > Index: linux-2.6/net/core/dev.c

Re: [PATCH] net: fix race in process_backlog

2007-10-03 Thread Stephen Hemminger
On Wed, 03 Oct 2007 14:58:07 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Peter Zijlstra <[EMAIL PROTECTED]> > Date: Wed, 03 Oct 2007 17:44:53 +0200 > > > Index: linux-2.6/net/core/dev.c > > === > > --- linux-2.6.orig/

Re: [PATCH] net: fix race in process_backlog

2007-10-03 Thread David Miller
From: Peter Zijlstra <[EMAIL PROTECTED]> Date: Wed, 03 Oct 2007 17:44:53 +0200 > Index: linux-2.6/net/core/dev.c > === > --- linux-2.6.orig/net/core/dev.c > +++ linux-2.6/net/core/dev.c > @@ -2095,11 +2095,11 @@ static int process_bac

Re: [PATCH] net: fix race in process_backlog

2007-10-03 Thread Stephen Hemminger
On Wed, 03 Oct 2007 17:44:53 +0200 Peter Zijlstra <[EMAIL PROTECTED]> wrote: > Subject: net: fix race in process_backlog > > The recent NAPI rework (4fa57c9ea9f36f9ca852f3a88ca5d2f1aebbc960) > introduced a race between netif_rx() and process_backlog() which > resulted in softirq processing to dro

[PATCH] net: fix race in process_backlog

2007-10-03 Thread Peter Zijlstra
Subject: net: fix race in process_backlog The recent NAPI rework (4fa57c9ea9f36f9ca852f3a88ca5d2f1aebbc960) introduced a race between netif_rx() and process_backlog() which resulted in softirq processing to drop dead. netif_rx() process_backlog() irq_disable(