Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread David Miller
From: Tony Battersby <[EMAIL PROTECTED]> Date: Thu, 04 Oct 2007 18:12:53 -0400 > Here is an example of what I would consider "reasonable code" that would > fail: > > int example() > { > struct socket *conn_socket = NULL; > int err; > > ... > > if ((err = kernel_accept(sock, &con

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread Tony Battersby
James Morris wrote: > On Thu, 4 Oct 2007, Tony Battersby wrote: > > >> If accept() returns an error, kernel_accept() releases the new socket >> but passes a pointer to the released socket back to the caller. Make it >> pass back NULL instead. >> >> Signed-off-by: Tony Battersby <[EMAIL PROTECTE

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread David Miller
From: James Morris <[EMAIL PROTECTED]> Date: Thu, 4 Oct 2007 14:57:33 -0700 (PDT) > On Thu, 4 Oct 2007, Tony Battersby wrote: > > > If accept() returns an error, kernel_accept() releases the new socket > > but passes a pointer to the released socket back to the caller. Make it > > pass back NULL

Re: [PATCH] net: fix kernel_accept() error path

2007-10-04 Thread James Morris
On Thu, 4 Oct 2007, Tony Battersby wrote: > If accept() returns an error, kernel_accept() releases the new socket > but passes a pointer to the released socket back to the caller. Make it > pass back NULL instead. > > Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> > --- > --- linux-2.6.23-rc9

[PATCH] net: fix kernel_accept() error path

2007-10-04 Thread Tony Battersby
If accept() returns an error, kernel_accept() releases the new socket but passes a pointer to the released socket back to the caller. Make it pass back NULL instead. Signed-off-by: Tony Battersby <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc9/net/socket.c.bak 2007-10-04 15:21:17.0 -0400 +