Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-06 Thread David Miller
From: Lucas Stach Date: Mon, 3 Aug 2015 17:50:11 +0200 > The clocks are initially active and thus the device is marked active. > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > call at the end of probe then leaves us with an invalid refcount of -1, > which in turn leads

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-04 Thread Alan Stern
On Tue, 4 Aug 2015, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hello, > > On Tue, Aug 04, 2015 at 10:20:55AM -0400, Alan Stern wrote: > > In that case, adding a call pm_runtime_get_noresume() is the right > > thing to do. > Is this an ack for Lucas' patch? Yes: Acked-by: Alan Stern Alan Stern -

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-04 Thread Uwe Kleine-König
Hello, On Tue, Aug 04, 2015 at 10:20:55AM -0400, Alan Stern wrote: > In that case, adding a call pm_runtime_get_noresume() is the right > thing to do. Is this an ack for Lucas' patch? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linu

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-04 Thread Alan Stern
On Tue, 4 Aug 2015, Lucas Stach wrote: > Am Montag, den 03.08.2015, 14:28 -0400 schrieb Alan Stern: > > On Mon, 3 Aug 2015, Uwe [iso-8859-1] Kleine-Knig wrote: > > > > > Hello, > > > > > > I have no clue about runtime-pm, but I added a few people to Cc: who > > > should know better ... > > > >

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-04 Thread Uwe Kleine-König
Hello Lucas, On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > The clocks are initially active and thus the device is marked active. > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > call at the end of probe then leaves us with an invalid refcount of -1, > wh

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-04 Thread Lucas Stach
Am Montag, den 03.08.2015, 14:28 -0400 schrieb Alan Stern: > On Mon, 3 Aug 2015, Uwe [iso-8859-1] Kleine-Knig wrote: > > > Hello, > > > > I have no clue about runtime-pm, but I added a few people to Cc: who > > should know better ... > > > > Best regards > > Uwe > > > > On Mon, Aug 03, 2015 at

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-04 Thread Lucas Stach
Am Montag, den 03.08.2015, 18:15 +0200 schrieb Andrew Lunn: > On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > > The clocks are initially active and thus the device is marked active. > > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > > call at the end of pro

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread David Miller
From: Lucas Stach Date: Mon, 3 Aug 2015 17:50:11 +0200 > The clocks are initially active and thus the device is marked active. > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > call at the end of probe then leaves us with an invalid refcount of -1, > which in turn leads

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Alan Stern
On Mon, 3 Aug 2015, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hello, > > I have no clue about runtime-pm, but I added a few people to Cc: who > should know better ... > > Best regards > Uwe > > On Mon, Aug 03, 2015 at 06:15:54PM +0200, Andrew Lunn wrote: > > On Mon, Aug 03, 2015 at 05:50:11PM +020

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Uwe Kleine-König
Hello, I have no clue about runtime-pm, but I added a few people to Cc: who should know better ... Best regards Uwe On Mon, Aug 03, 2015 at 06:15:54PM +0200, Andrew Lunn wrote: > On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > > The clocks are initially active and thus the device

Re: [PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Andrew Lunn
On Mon, Aug 03, 2015 at 05:50:11PM +0200, Lucas Stach wrote: > The clocks are initially active and thus the device is marked active. > This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() > call at the end of probe then leaves us with an invalid refcount of -1, > which in turn le

[PATCH] net: fec: fix initial runtime PM refcount

2015-08-03 Thread Lucas Stach
The clocks are initially active and thus the device is marked active. This still keeps the PM refcount at 0, the pm_runtime_put_autosuspend() call at the end of probe then leaves us with an invalid refcount of -1, which in turn leads to the device staying in suspended state even though netdev open