Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

2020-05-27 Thread David Miller
From: Bartosz Golaszewski Date: Wed, 27 May 2020 11:24:04 +0200 > From: Bartosz Golaszewski > > The dma_addr field in desc_data must not be overwritten until after the > new skb is mapped. Currently we do replace it with uninitialized value > in error path. This change fixes it by moving the as

Re: [PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

2020-05-27 Thread Nathan Chancellor
On Wed, May 27, 2020 at 11:24:04AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The dma_addr field in desc_data must not be overwritten until after the > new skb is mapped. Currently we do replace it with uninitialized value > in error path. This change fixes it by moving the

[PATCH] net: ethernet: mtk-star-emac: fix error path in RX handling

2020-05-27 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The dma_addr field in desc_data must not be overwritten until after the new skb is mapped. Currently we do replace it with uninitialized value in error path. This change fixes it by moving the assignment before the label to which we jump after mapping or allocation error