Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Sergei Shtylyov
On 02/04/2016 11:42 PM, Robert Jarzmik wrote: Your patch summary prefixes are too verbose, it was enough to say only "dm9000: ". Or "davicom: dm9000: ". Missing the driver name itself doesn't look very consistent. :-) Well, I don't agree here. The subsystem should be fully specified

Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Robert Jarzmik
Sergei Shtylyov writes: > Hello. > >Your patch summary prefixes are too verbose, it was enough to say only > "dm9000: ". Well, I don't agree here. The subsystem should be fully specified, at least this is something I require in pxa, something that is also required in sound/*, etc ... If David

Re: [PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-04 Thread Sergei Shtylyov
Hello. Your patch summary prefixes are too verbose, it was enough to say only "dm9000: ". On 02/04/2016 12:40 AM, Robert Jarzmik wrote: The dm9000 driver doesn't work in at least one device-tree configuration, spitting an error message on irq resource : [1.062495] dm9000 800.ether

[PATCH] net: ethernet: davicom: fix devicetree irq resource

2016-02-03 Thread Robert Jarzmik
The dm9000 driver doesn't work in at least one device-tree configuration, spitting an error message on irq resource : [1.062495] dm9000 800.ethernet: insufficient resources [1.068439] dm9000 800.ethernet: not found (-2). [1.073451] dm9000: probe of 800.ethernet failed with e