Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-05 Thread David Miller
From: Florian Fainelli Date: Sat, 2 Feb 2019 09:05:11 -0800 > Le 2/2/19 à 6:29 AM, Rundong Ge a écrit : >> The unbalance of master's promiscuity or allmulti will happen after ifdown >> and ifup a slave interface which is in a bridge. >> >> When we ifdown a slave interface , both the 'dsa_slave_c

Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread 戈润栋
Hi Andrew Sorry for the previous mails due to my error mail format setting on browser. I have reproduced the tcpdump issue in my env, but not sure if it is the same issue as you mentioned. Ifdown a slave interface which is under tcpdump capturing will also decrease the master's promiscuous twice.

Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread Andrew Lunn
On Sat, Feb 02, 2019 at 09:05:11AM -0800, Florian Fainelli wrote: > Le 2/2/19 à 6:29 AM, Rundong Ge a écrit : > > The unbalance of master's promiscuity or allmulti will happen after ifdown > > and ifup a slave interface which is in a bridge. > > > > When we ifdown a slave interface , both the 'dsa

Re: [PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread Florian Fainelli
Le 2/2/19 à 6:29 AM, Rundong Ge a écrit : > The unbalance of master's promiscuity or allmulti will happen after ifdown > and ifup a slave interface which is in a bridge. > > When we ifdown a slave interface , both the 'dsa_slave_close' and > 'dsa_slave_change_rx_flags' will clear the master's flag

[PATCH] net: dsa: slave: Don't propagate flag changes on down slave interfaces

2019-02-02 Thread Rundong Ge
The unbalance of master's promiscuity or allmulti will happen after ifdown and ifup a slave interface which is in a bridge. When we ifdown a slave interface , both the 'dsa_slave_close' and 'dsa_slave_change_rx_flags' will clear the master's flags. The flags of master will be decrease twice. In th