Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-10-02 Thread David Miller
From: Linus Walleij Date: Tue, 1 Oct 2019 16:28:43 +0200 > There has been some confusion between the port number and > the VLAN ID in this driver. What we need to check for > validity is the VLAN ID, nothing else. > > The current confusion came from assigning a few default > VLANs for default r

[PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-10-01 Thread Linus Walleij
There has been some confusion between the port number and the VLAN ID in this driver. What we need to check for validity is the VLAN ID, nothing else. The current confusion came from assigning a few default VLANs for default routing and we need to rewrite that properly. Instead of checking if the

Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-09-28 Thread Linus Walleij
On Sat, Sep 28, 2019 at 10:36 PM Florian Fainelli wrote: > Do we need to duplicate the same is_vlan_valid() check in both the > vlan_prepare and vlan_add callbacks? I'm unsure of the semantics of these calls, the check was in the OpenWrt driver that I started from. Is it guaranteed that .vlan_p

Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-09-28 Thread Florian Fainelli
On 9/28/2019 1:26 PM, Linus Walleij wrote: > On Fri, Sep 27, 2019 at 6:40 PM Florian Fainelli wrote: >> On 9/27/19 9:39 AM, Linus Walleij wrote: >>> There has been some confusion between the port number and >>> the VLAN ID in this driver. What we need to check for >>> validity is the VLAN ID, n

Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-09-28 Thread Linus Walleij
On Fri, Sep 27, 2019 at 6:40 PM Florian Fainelli wrote: > On 9/27/19 9:39 AM, Linus Walleij wrote: > > There has been some confusion between the port number and > > the VLAN ID in this driver. What we need to check for > > validity is the VLAN ID, nothing else. > > > > The current confusion came f

Re: [PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-09-27 Thread Florian Fainelli
On 9/27/19 9:39 AM, Linus Walleij wrote: > There has been some confusion between the port number and > the VLAN ID in this driver. What we need to check for > validity is the VLAN ID, nothing else. > > The current confusion came from assigning a few default > VLANs for default routing and we need

[PATCH] net: dsa: rtl8366: Check VLAN ID and not ports

2019-09-27 Thread Linus Walleij
There has been some confusion between the port number and the VLAN ID in this driver. What we need to check for validity is the VLAN ID, nothing else. The current confusion came from assigning a few default VLANs for default routing and we need to rewrite that properly. Instead of checking if the