Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-30 Thread David Miller
From: Arnd Bergmann Date: Mon, 29 May 2017 14:56:01 +0200 > 'static' was not enough, the helpers must be 'static inline' > > net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' > defined but not used [-Werror=unused-function] > net/dsa/mv88e6xxx/global2.h:117:12: error: 'm

Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-30 Thread Andrew Lunn
On Mon, May 29, 2017 at 11:06:51PM +0200, Arnd Bergmann wrote: > On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn wrote: > > On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote: > >> 'static' was not enough, the helpers must be 'static inline' > >> > >> net/dsa/mv88e6xxx/global2.h:123:12: er

Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-29 Thread Arnd Bergmann
On Mon, May 29, 2017 at 5:30 PM, Andrew Lunn wrote: > On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote: >> 'static' was not enough, the helpers must be 'static inline' >> >> net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' >> defined but not used [-Werror=unu

Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-29 Thread Andrew Lunn
On Mon, May 29, 2017 at 02:56:01PM +0200, Arnd Bergmann wrote: > 'static' was not enough, the helpers must be 'static inline' > > net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' > defined but not used [-Werror=unused-function] > net/dsa/mv88e6xxx/global2.h:117:12: error:

Re: [PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-29 Thread Vivien Didelot
Hi Arnd, Arnd Bergmann writes: > 'static' was not enough, the helpers must be 'static inline' > > net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' > defined but not used [-Werror=unused-function] > net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defi

[PATCH] net: dsa: mv88e6xxx: Add missing static to stub functions

2017-05-29 Thread Arnd Bergmann
'static' was not enough, the helpers must be 'static inline' net/dsa/mv88e6xxx/global2.h:123:12: error: 'mv88e6xxx_g2_misc_4_bit_port' defined but not used [-Werror=unused-function] net/dsa/mv88e6xxx/global2.h:117:12: error: 'mv88e6xxx_g2_pvt_write' defined but not used [-Werror=unused-function]