Re: Decoupling phy_device from net_device (was "Re: [PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN")

2019-05-06 Thread Andrew Lunn
On Mon, May 06, 2019 at 01:00:49AM +0300, Vladimir Oltean wrote: > On 4/12/19 8:57 PM, Heiner Kallweit wrote: > >On 12.04.2019 01:01, Vladimir Oltean wrote: > >>With Heiner's recent patch "b6163f194c69 net: phy: improve > >>genphy_read_status", the phydev->speed is now initialized by default to > >

Re: Decoupling phy_device from net_device (was "Re: [PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN")

2019-05-05 Thread Florian Fainelli
On May 5, 2019 3:00:49 PM PDT, Vladimir Oltean wrote: >On 4/12/19 8:57 PM, Heiner Kallweit wrote: >> On 12.04.2019 01:01, Vladimir Oltean wrote: >>> With Heiner's recent patch "b6163f194c69 net: phy: improve >>> genphy_read_status", the phydev->speed is now initialized by default >to >>> SPEED_

Decoupling phy_device from net_device (was "Re: [PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN")

2019-05-05 Thread Vladimir Oltean
On 4/12/19 8:57 PM, Heiner Kallweit wrote: On 12.04.2019 01:01, Vladimir Oltean wrote: With Heiner's recent patch "b6163f194c69 net: phy: improve genphy_read_status", the phydev->speed is now initialized by default to SPEED_UNKNOWN even for fixed PHYs. This is not necessarily bad, since it is no

Re: [PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN

2019-04-12 Thread Heiner Kallweit
On 12.04.2019 01:01, Vladimir Oltean wrote: > With Heiner's recent patch "b6163f194c69 net: phy: improve > genphy_read_status", the phydev->speed is now initialized by default to > SPEED_UNKNOWN even for fixed PHYs. This is not necessarily bad, since it > is not correct to call genphy_config_init()

[PATCH] net: dsa: fixed-link interface is reporting SPEED_UNKNOWN

2019-04-11 Thread Vladimir Oltean
With Heiner's recent patch "b6163f194c69 net: phy: improve genphy_read_status", the phydev->speed is now initialized by default to SPEED_UNKNOWN even for fixed PHYs. This is not necessarily bad, since it is not correct to call genphy_config_init() and genphy_read_status() for a fixed PHY. This dat