Re: [PATCH] net: dsa: fix fixed-link-phy device leaks

2016-11-17 Thread Johan Hovold
On Thu, Nov 17, 2016 at 10:52:25AM +0100, Johan Hovold wrote: > On Wed, Nov 16, 2016 at 10:14:10AM -0800, Florian Fainelli wrote: > > On 11/16/2016 09:11 AM, Johan Hovold wrote: > > > On Wed, Nov 16, 2016 at 09:06:26AM -0800, Florian Fainelli wrote: > > >> On 11/16/2016 06:47 AM, Johan Hovold wrote

Re: [PATCH] net: dsa: fix fixed-link-phy device leaks

2016-11-17 Thread Johan Hovold
On Wed, Nov 16, 2016 at 10:14:10AM -0800, Florian Fainelli wrote: > On 11/16/2016 09:11 AM, Johan Hovold wrote: > > On Wed, Nov 16, 2016 at 09:06:26AM -0800, Florian Fainelli wrote: > >> On 11/16/2016 06:47 AM, Johan Hovold wrote: > >>> Make sure to drop the reference taken by of_phy_find_device()

Re: [PATCH] net: dsa: fix fixed-link-phy device leaks

2016-11-16 Thread Florian Fainelli
On 11/16/2016 09:11 AM, Johan Hovold wrote: > On Wed, Nov 16, 2016 at 09:06:26AM -0800, Florian Fainelli wrote: >> On 11/16/2016 06:47 AM, Johan Hovold wrote: >>> Make sure to drop the reference taken by of_phy_find_device() when >>> registering and deregistering the fixed-link PHY-device. >>> >>>

Re: [PATCH] net: dsa: fix fixed-link-phy device leaks

2016-11-16 Thread Johan Hovold
On Wed, Nov 16, 2016 at 09:06:26AM -0800, Florian Fainelli wrote: > On 11/16/2016 06:47 AM, Johan Hovold wrote: > > Make sure to drop the reference taken by of_phy_find_device() when > > registering and deregistering the fixed-link PHY-device. > > > > Note that we need to put both references held

Re: [PATCH] net: dsa: fix fixed-link-phy device leaks

2016-11-16 Thread Florian Fainelli
On 11/16/2016 06:47 AM, Johan Hovold wrote: > Make sure to drop the reference taken by of_phy_find_device() when > registering and deregistering the fixed-link PHY-device. > > Note that we need to put both references held at deregistration. > > Fixes: 39b0c705195e ("net: dsa: Allow configuration

[PATCH] net: dsa: fix fixed-link-phy device leaks

2016-11-16 Thread Johan Hovold
Make sure to drop the reference taken by of_phy_find_device() when registering and deregistering the fixed-link PHY-device. Note that we need to put both references held at deregistration. Fixes: 39b0c705195e ("net: dsa: Allow configuration of CPU & DSA port speeds/duplex") Signed-off-by: Johan H