Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Julia Lawall
On Tue, 9 Aug 2016, Florian Fainelli wrote: > On 08/09/2016 09:58 AM, Julia Lawall wrote: > > The xfrm_replay structures are never modified, so declare them as const. > > You mean b53_io_ops here, right? Oops. I sent a v2. julia > Other than that LTGM, but this will > have to wait for "net"n

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Florian Fainelli
On 08/09/2016 10:23 AM, Florian Fainelli wrote: > On 08/09/2016 09:58 AM, Julia Lawall wrote: >> The xfrm_replay structures are never modified, so declare them as const. > > You mean b53_io_ops here, right? Other than that LTGM, but this will > have to wait for "net"next to re_open since this is m

Re: [PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Florian Fainelli
On 08/09/2016 09:58 AM, Julia Lawall wrote: > The xfrm_replay structures are never modified, so declare them as const. You mean b53_io_ops here, right? Other than that LTGM, but this will have to wait for "net"next to re_open since this is more of a cleanup than bugfix. Thanks! -- Florian

[PATCH] net: dsa: b53: constify xfrm_replay structures

2016-08-09 Thread Julia Lawall
The xfrm_replay structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/dsa/b53/b53_common.c |3 ++- drivers/net/dsa/b53/b53_mdio.c |2 +- drivers/net/dsa/b53/b53_mmap.c |2 +- drivers/net/dsa/b53/b5