Re: [PATCH] net: dsa: Inherit dev addr from master

2019-03-26 Thread xiaofeis
On 2019-02-25 21:21, Andrew Lunn wrote: I think we can remove the first inherit, but if keep it, we can see consistent address output by ifconfig -a before open master and slave interface. True But it also means we see inconsistent MAC addresses on the master. The MAC address changes on open.

Re: [PATCH] net: dsa: Inherit dev addr from master

2019-02-25 Thread Andrew Lunn
> I think we can remove the first inherit, but if keep it, we can see > consistent address output by ifconfig -a before open master and slave > interface. True But it also means we see inconsistent MAC addresses on the master. The MAC address changes on open. Maybe it would be better to change y

Re: [PATCH] net: dsa: Inherit dev addr from master

2019-02-25 Thread xiaofeis
On 2019-02-22 22:30, Andrew Lunn wrote: On Fri, Feb 22, 2019 at 06:26:54PM +0530, Vinod Koul wrote: From: Xiaofei Shen When we create slave netdevice, the dev addr is inherited from master but the master dev addr maybe NULL at that time, so inherit it again while opening the slave. Hi Xiaofe

Re: [PATCH] net: dsa: Inherit dev addr from master

2019-02-22 Thread Andrew Lunn
On Fri, Feb 22, 2019 at 06:26:54PM +0530, Vinod Koul wrote: > From: Xiaofei Shen > > When we create slave netdevice, the dev addr is inherited from master > but the master dev addr maybe NULL at that time, so inherit it again > while opening the slave. Hi Xiaofei, Vinod Inheriting it twice seem

[PATCH] net: dsa: Inherit dev addr from master

2019-02-22 Thread Vinod Koul
From: Xiaofei Shen When we create slave netdevice, the dev addr is inherited from master but the master dev addr maybe NULL at that time, so inherit it again while opening the slave. Signed-off-by: Xiaofei Shen Signed-off-by: Vinod Koul --- net/dsa/slave.c | 4 +++- 1 file changed, 3 insertio