Re: [PATCH] net: dsa: Add of_node_put() before break statement

2020-08-23 Thread Andrew Lunn
On Sun, Aug 23, 2020 at 07:31:16PM +0530, Sumera Priyadarsini wrote: > Every iteration of for_each_child_of_node() decrements > the reference count of the previous node, however when control > is transferred from the middle of the loop, as in the case of > a return or break or goto, there is no dec

[PATCH] net: dsa: Add of_node_put() before break statement

2020-08-23 Thread Sumera Priyadarsini
Every iteration of for_each_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory le