Re: [PATCH] net: diag: Fix refcnt leak in error path destroying socket

2016-08-23 Thread David Miller
From: David Ahern Date: Tue, 23 Aug 2016 21:05:27 -0700 > inet_diag_find_one_icsk takes a reference to a socket that is not > released if sock_diag_destroy returns an error. Fix by changing > tcp_diag_destroy to manage the refcnt for all cases and remove > the sock_put calls from tcp_abort. > >

[PATCH] net: diag: Fix refcnt leak in error path destroying socket

2016-08-23 Thread David Ahern
inet_diag_find_one_icsk takes a reference to a socket that is not released if sock_diag_destroy returns an error. Fix by changing tcp_diag_destroy to manage the refcnt for all cases and remove the sock_put calls from tcp_abort. Fixes: c1e64e298b8ca ("net: diag: Support destroying TCP sockets") Rep