Re: [PATCH] net: deal wrong skb and failure ret from __tcp_retransmit_skb

2018-04-19 Thread Liu, Changcheng
On 06:40 Thu 19 Apr, Eric Dumazet wrote: > > > On 04/19/2018 04:26 AM, Liu, Changcheng wrote: > > Hit below panic due to skb is NULL, WARN wrong skb first. > > if __tcp_retransmit_skb return failure e.g. -EAGAIN, it > > needn't do further action in tcp_retransmit_skb. > > > > gdb vmlinux > > Rea

Re: [PATCH] net: deal wrong skb and failure ret from __tcp_retransmit_skb

2018-04-19 Thread Eric Dumazet
On 04/19/2018 04:26 AM, Liu, Changcheng wrote: > Hit below panic due to skb is NULL, WARN wrong skb first. > if __tcp_retransmit_skb return failure e.g. -EAGAIN, it > needn't do further action in tcp_retransmit_skb. > > gdb vmlinux > Reading symbols from vmlinux...done. > (gdb) p &((struct tcp_s

[PATCH] net: deal wrong skb and failure ret from __tcp_retransmit_skb

2018-04-19 Thread Liu, Changcheng
Hit below panic due to skb is NULL, WARN wrong skb first. if __tcp_retransmit_skb return failure e.g. -EAGAIN, it needn't do further action in tcp_retransmit_skb. gdb vmlinux Reading symbols from vmlinux...done. (gdb) p &((struct tcp_skb_cb *) \ &(((struct sk_buff *)0)->cb[0]))->tcp_gso_segs $1 =