Re: [PATCH] net: core: skbuff: skb_checksum_setup() drop err

2019-10-13 Thread Eric Dumazet
On 10/13/19 1:17 PM, Vito Caputo wrote: > > Except there are examples under net/core of precisely this pattern, e.g.: > > We do not care about having consistent code styles. linux kernel has been contributed by thousands. Each contributor has its own preferences. We do not want to enforce

Re: [PATCH] net: core: skbuff: skb_checksum_setup() drop err

2019-10-13 Thread Vito Caputo
On Sun, Oct 13, 2019 at 12:58:04PM -0700, Eric Dumazet wrote: > > > On 10/12/19 5:30 PM, Vito Caputo wrote: > > Return directly from all switch cases, no point in storing in err. > > > > Signed-off-by: Vito Caputo > > --- > > net/core/skbuff.c | 15 +++ > > 1 file changed, 3 insert

Re: [PATCH] net: core: skbuff: skb_checksum_setup() drop err

2019-10-13 Thread Eric Dumazet
On 10/12/19 5:30 PM, Vito Caputo wrote: > Return directly from all switch cases, no point in storing in err. > > Signed-off-by: Vito Caputo > --- > net/core/skbuff.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/net/core/skbuff.c b/net/core/skbuff.