Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-30 Thread Jakub Kicinski
On Wed, 28 Oct 2020 12:35:33 +0100 Lukas Bulwahn wrote: > make clang-analyzer on x86_64 defconfig caught my attention with: > > net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read > [clang-analyzer-deadcode.DeadStores] > parent = 0; > ^ >

Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Tom Rix
On 10/28/20 4:35 AM, Lukas Bulwahn wrote: > make clang-analyzer on x86_64 defconfig caught my attention with: > > net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read > [clang-analyzer-deadcode.DeadStores] > parent = 0; > ^ > > net/sched/cl

Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Lukas Bulwahn
On Wed, 28 Oct 2020, Tom Rix wrote: > > On 10/28/20 4:35 AM, Lukas Bulwahn wrote: > > make clang-analyzer on x86_64 defconfig caught my attention with: > > > > net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read > > [clang-analyzer-deadcode.DeadStores] > >

[PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Lukas Bulwahn
make clang-analyzer on x86_64 defconfig caught my attention with: net/sched/cls_api.c:2964:3: warning: Value stored to 'parent' is never read [clang-analyzer-deadcode.DeadStores] parent = 0; ^ net/sched/cls_api.c:2977:4: warning: Value stored to 'parent' is never

Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Cong Wang
On Wed, Oct 28, 2020 at 6:59 AM Tom Rix wrote: > > > On 10/28/20 4:35 AM, Lukas Bulwahn wrote: > > @@ -2971,13 +2963,11 @@ static int tc_dump_chain(struct sk_buff *skb, > > struct netlink_callback *cb) > > if (!dev) > > return skb->len; > > > > - pa