Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-11 Thread David Miller
From: Kosuke Tatsukawa Date: Wed, 6 Sep 2017 22:47:59 + > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded va

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-11 Thread Nikolay Aleksandrov
On 11 September 2017 19:07:33 EEST, "Mahesh Bandewar (महेश बंडेवार)" wrote: >On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov > wrote: >> On 07/09/17 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transm

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-11 Thread महेश बंडेवार
On Sat, Sep 9, 2017 at 4:28 AM, Nikolay Aleksandrov wrote: > On 07/09/17 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode, which wasn't working after commit

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-09 Thread Nikolay Aleksandrov
On 07/09/17 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded value"). > > It turn

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-09 Thread Nikolay Aleksandrov
On 09/09/17 13:29, Nikolay Aleksandrov wrote: > On 09/09/17 02:54, Mahesh Bandewar (महेश बंडेवार) wrote: >> On Fri, Sep 8, 2017 at 7:30 AM, Nikolay Aleksandrov >> wrote: >>> On 08/09/17 17:17, Kosuke Tatsukawa wrote: [snip] >>> >> I think the underlying issue is that tlb_dynamic_lb should be set t

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-09 Thread Nikolay Aleksandrov
On 09/09/17 02:54, Mahesh Bandewar (महेश बंडेवार) wrote: > On Fri, Sep 8, 2017 at 7:30 AM, Nikolay Aleksandrov > wrote: >> On 08/09/17 17:17, Kosuke Tatsukawa wrote: >>> Hi, >>> On 08/09/17 13:10, Nikolay Aleksandrov wrote: > On 08/09/17 05:06, Kosuke Tatsukawa wrote: >> Hi, >> >>

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-08 Thread महेश बंडेवार
On Fri, Sep 8, 2017 at 7:30 AM, Nikolay Aleksandrov wrote: > On 08/09/17 17:17, Kosuke Tatsukawa wrote: >> Hi, >> >>> On 08/09/17 13:10, Nikolay Aleksandrov wrote: On 08/09/17 05:06, Kosuke Tatsukawa wrote: > Hi, > >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-08 Thread Nikolay Aleksandrov
On 08/09/17 17:17, Kosuke Tatsukawa wrote: > Hi, > >> On 08/09/17 13:10, Nikolay Aleksandrov wrote: >>> On 08/09/17 05:06, Kosuke Tatsukawa wrote: Hi, > On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balan

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-08 Thread Kosuke Tatsukawa
Hi, > On 08/09/17 13:10, Nikolay Aleksandrov wrote: >> On 08/09/17 05:06, Kosuke Tatsukawa wrote: >>> Hi, >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balan

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-08 Thread Nikolay Aleksandrov
On 08/09/17 13:10, Nikolay Aleksandrov wrote: > On 08/09/17 05:06, Kosuke Tatsukawa wrote: >> Hi, >> >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in balance-alb mode") tried to fix transmit dynamic load balancing in

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-08 Thread Nikolay Aleksandrov
On 08/09/17 05:06, Kosuke Tatsukawa wrote: > Hi, > >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transmit dynamic load balancing in >>> balance-alb mode, which wasn't working after commit 8

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-07 Thread Kosuke Tatsukawa
Hi, > On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode, which wasn't working after commit 8b426dc54cf4 >> ("bonding: remove hardcoded value").

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-07 Thread महेश बंडेवार
On Thu, Sep 7, 2017 at 5:47 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Sep 7, 2017 at 5:39 PM, Mahesh Bandewar (महेश बंडेवार) > wrote: >> On Thu, Sep 7, 2017 at 4:09 PM, Nikolay Aleksandrov >> wrote: >>> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: Commit cbf5ecb30560 ("net: bondin

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-07 Thread महेश बंडेवार
On Thu, Sep 7, 2017 at 5:39 PM, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Sep 7, 2017 at 4:09 PM, Nikolay Aleksandrov > wrote: >> On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >>> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >>> balance-alb mode") tried to fix transmit

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-07 Thread महेश बंडेवार
On Thu, Sep 7, 2017 at 4:09 PM, Nikolay Aleksandrov wrote: > On 7.09.2017 01:47, Kosuke Tatsukawa wrote: >> Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in >> balance-alb mode") tried to fix transmit dynamic load balancing in >> balance-alb mode, which wasn't working after comm

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-07 Thread Nikolay Aleksandrov
On 7.09.2017 01:47, Kosuke Tatsukawa wrote: > Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in > balance-alb mode") tried to fix transmit dynamic load balancing in > balance-alb mode, which wasn't working after commit 8b426dc54cf4 > ("bonding: remove hardcoded value"). > > It tu

[PATCH] net: bonding: Fix transmit load balancing in balance-alb mode if specified by sysfs

2017-09-06 Thread Kosuke Tatsukawa
Commit cbf5ecb30560 ("net: bonding: Fix transmit load balancing in balance-alb mode") tried to fix transmit dynamic load balancing in balance-alb mode, which wasn't working after commit 8b426dc54cf4 ("bonding: remove hardcoded value"). It turned out that my previous patch only fixed the case when

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-09-06 Thread Kosuke Tatsukawa
Reinis Rozitis reported that tlb_dynamic_lb was still 0 in balance-alb mode even when using linux-4.12.10 kernels, which includes this patch. It turned out that my previous patch only fixed the case when balance-alb mode was specified as bonding module parameter, and not when balance-alb mode was

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-07-20 Thread David Miller
From: Kosuke Tatsukawa Date: Thu, 20 Jul 2017 05:20:40 + > balance-alb mode used to have transmit dynamic load balancing feature > enabled by default. However, transmit dynamic load balancing no longer > works in balance-alb after commit 8b426dc54cf4 ("bonding: remove > hardcoded value"). >

Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-07-20 Thread Andy Gospodarek
On Thu, Jul 20, 2017 at 1:20 AM, Kosuke Tatsukawa wrote: > balance-alb mode used to have transmit dynamic load balancing feature > enabled by default. However, transmit dynamic load balancing no longer > works in balance-alb after commit 8b426dc54cf4 ("bonding: remove > hardcoded value"). > > Bot

[PATCH] net: bonding: Fix transmit load balancing in balance-alb mode

2017-07-19 Thread Kosuke Tatsukawa
balance-alb mode used to have transmit dynamic load balancing feature enabled by default. However, transmit dynamic load balancing no longer works in balance-alb after commit 8b426dc54cf4 ("bonding: remove hardcoded value"). Both balance-tlb and balance-alb use the function bond_do_alb_xmit() to