Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Ion Badulescu
On 11/20/20 6:56 PM, Jakub Kicinski wrote: On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote: Frankly, no, I don't know of any users, and that unfortunately includes myself. I still have two cards in my stash, but they're 64-bit PCI-X, so plugging them in would likely require taking a dreme

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 18:41:03 -0500 Ion Badulescu wrote: > Frankly, no, I don't know of any users, and that unfortunately includes > myself. I still have two cards in my stash, but they're 64-bit PCI-X, so > plugging them in would likely require taking a dremel to a 32-bit PCI > slot to make it o

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Ion Badulescu
On 11/20/20 6:17 PM, Jakub Kicinski wrote: On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1...@gmail.com wrote: From: Kaixu Xia The body of the if statement can be executed only when the variable vlan_count equals to 32, so the condition of the while statement can not be true and the while stateme

Re: [PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-20 Thread Jakub Kicinski
On Fri, 20 Nov 2020 15:50:00 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The body of the if statement can be executed only when the variable > vlan_count equals to 32, so the condition of the while statement can > not be true and the while statement is dead code. Remove it. > > Rep

[PATCH] net: adaptec: remove dead code in set_vlan_mode

2020-11-19 Thread xiakaixu1987
From: Kaixu Xia The body of the if statement can be executed only when the variable vlan_count equals to 32, so the condition of the while statement can not be true and the while statement is dead code. Remove it. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/net/ethernet/adapt