[PATCH] [NET]: Move destructor from neigh->ops to neigh_params

2006-03-07 Thread Roland Dreier
Here's the fixed version of the original patch. --- From: Michael S. Tsirkin <[EMAIL PROTECTED]> struct neigh_ops currently has a destructor field, which no in-kernel drivers outside of infiniband use. The infiniband/ulp/ipoib in-tree driver stashes some info in the neighbour structure (the res

Re: [PATCH] net: Move destructor from neigh->ops to neigh_params

2006-03-06 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 06 Mar 2006 21:44:50 -0800 > Roland> struct neigh_ops currently has a destructor field, which > Roland> no in-kernel drivers outside of infiniband use. > > Andrew> net/atm/clip.c begs to disagree. > > err... my fault for trusting the

Re: [PATCH] net: Move destructor from neigh->ops to neigh_params

2006-03-06 Thread Roland Dreier
Andrew> I'm also wondering why a combination of the net and Andrew> infiniband trees does this: Andrew> drivers/infiniband/ulp/ipoib/ipoib_multicast.c: In Andrew> function `ipoib_mcast_free': Andrew> drivers/infiniband/ulp/ipoib/ipoib_multicast.c:118: error: Andrew> structu

Re: [PATCH] net: Move destructor from neigh->ops to neigh_params

2006-03-06 Thread Roland Dreier
Roland> struct neigh_ops currently has a destructor field, which Roland> no in-kernel drivers outside of infiniband use. Andrew> net/atm/clip.c begs to disagree. err... my fault for trusting the patch changelog and not double-checking. I think the fix is as simple as, although, given

Re: [PATCH] net: Move destructor from neigh->ops to neigh_params

2006-03-06 Thread Andrew Morton
Roland Dreier <[EMAIL PROTECTED]> wrote: > > struct neigh_ops currently has a destructor field, which no in-kernel > drivers outside of infiniband use. net/atm/clip.c begs to disagree. I'm also wondering why a combination of the net and infiniband trees does this: drivers/infiniband/ulp/ipoib/i

Re: [PATCH] net: Move destructor from neigh->ops to neigh_params

2006-01-23 Thread David S. Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Mon, 23 Jan 2006 13:27:32 -0800 > I'd like to get an ACK or NAK of it from Dave Dave is in New Zealand at linux.conf.au, don't expect him to be too active for at least a week... - To unsubscribe from this list: send the line "unsubscribe netdev" in t

[PATCH] net: Move destructor from neigh->ops to neigh_params

2006-01-23 Thread Roland Dreier
This is a resend of a patch written by Michael S. Tsirkin <[EMAIL PROTECTED]>. I'd like to get an ACK or NAK of it from Dave and other networking people, so that we can either merge it upstream or try a different approach. There definitely is a problem with neighbour destructors that IP-over-IB i