Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-14 Thread Jakub Kicinski
On Wed, 14 Apr 2021 17:31:55 -0400 Jonathon Reinhart wrote: > On Tue, Apr 13, 2021 at 2:23 PM Jakub Kicinski wrote: > > > > On Tue, 13 Apr 2021 03:08:48 -0400 Jonathon Reinhart wrote: > > > Fixes: 9cb8e048e5d9: ("net/ipv4/sysctl: show tcp_{allowed, > > > available}_congestion_control in non-ini

Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-14 Thread Jonathon Reinhart
On Tue, Apr 13, 2021 at 2:23 PM Jakub Kicinski wrote: > > On Tue, 13 Apr 2021 03:08:48 -0400 Jonathon Reinhart wrote: > > Fixes: 9cb8e048e5d9: ("net/ipv4/sysctl: show tcp_{allowed, > > available}_congestion_control in non-initial netns") > > nit: no semicolon after the hash Oops. scripts/checkpa

Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-13 Thread Jakub Kicinski
On Tue, 13 Apr 2021 03:08:48 -0400 Jonathon Reinhart wrote: > Fixes: 9cb8e048e5d9: ("net/ipv4/sysctl: show tcp_{allowed, > available}_congestion_control in non-initial netns") nit: no semicolon after the hash

Re: [PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-13 Thread Christian Brauner
On Tue, Apr 13, 2021 at 03:08:48AM -0400, Jonathon Reinhart wrote: > Currently, tcp_allowed_congestion_control is global and writable; > writing to it in any net namespace will leak into all other net > namespaces. > > tcp_available_congestion_control and tcp_allowed_congestion_control are > the o

[PATCH] net: Make tcp_allowed_congestion_control readonly in non-init netns

2021-04-13 Thread Jonathon Reinhart
Currently, tcp_allowed_congestion_control is global and writable; writing to it in any net namespace will leak into all other net namespaces. tcp_available_congestion_control and tcp_allowed_congestion_control are the only sysctls in ipv4_net_table (the per-netns sysctl table) with a NULL data poi