Re: [PATCH] net/xdp: remove unused macro REG_STATE_NEW

2020-11-10 Thread Jesper Dangaard Brouer
On Mon, 09 Nov 2020 13:44:48 -0800 John Fastabend wrote: > Alex Shi wrote: > > > > > > 在 2020/11/7 上午12:13, Jesper Dangaard Brouer 写道: > > > Hmm... REG_STATE_NEW is zero, so it is implicitly set via memset zero. > > > But it is true that it is technically not directly used or referenced. > >

Re: [PATCH] net/xdp: remove unused macro REG_STATE_NEW

2020-11-09 Thread John Fastabend
Alex Shi wrote: > > > 在 2020/11/7 上午12:13, Jesper Dangaard Brouer 写道: > > Hmm... REG_STATE_NEW is zero, so it is implicitly set via memset zero. > > But it is true that it is technically not directly used or referenced. > > > > It is mentioned in a comment, so please send V2 with this additional

Re: [PATCH] net/xdp: remove unused macro REG_STATE_NEW

2020-11-07 Thread Alex Shi
在 2020/11/7 上午12:13, Jesper Dangaard Brouer 写道: > Hmm... REG_STATE_NEW is zero, so it is implicitly set via memset zero. > But it is true that it is technically not directly used or referenced. > > It is mentioned in a comment, so please send V2 with this additional change: Hi Jesper, Thanks

Re: [PATCH] net/xdp: remove unused macro REG_STATE_NEW

2020-11-06 Thread Jesper Dangaard Brouer
On Fri, 6 Nov 2020 13:43:51 +0800 Alex Shi wrote: > To tame gcc warning on it: > net/core/xdp.c:20:0: warning: macro "REG_STATE_NEW" is not used > [-Wunused-macros] Hmm... REG_STATE_NEW is zero, so it is implicitly set via memset zero. But it is true that it is technically not directly used or

[PATCH] net/xdp: remove unused macro REG_STATE_NEW

2020-11-05 Thread Alex Shi
To tame gcc warning on it: net/core/xdp.c:20:0: warning: macro "REG_STATE_NEW" is not used [-Wunused-macros] Signed-off-by: Alex Shi Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Jesper Dangaard Brouer Cc: John Fastabend Cc: netdev@vger.kernel